Do not compile regexes on each run #3949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Keep a cache of already compiled regexes (they will always be the same) - Alphanumeric strings an be simply matched for `==` instead of using RE.
truthbk
previously approved these changes
Jun 20, 2019
| except Exception: | ||
| self.warning("Cannot compile regex: %s" % regex) | ||
| return [] | ||
| if key.isalnum(): |
therve
requested changes
Jun 20, 2019
albertvaka
force-pushed
the
albertvaka/reduce-re-compile
branch
from
309ab83
to
407d786
Compare
Codecov Report
@@ Coverage Diff @@
## master #3949 +/- ##
==========================================
+ Coverage 79.47% 88.88% +9.41%
==========================================
Files 158 7 -151
Lines 8250 270 -7980
Branches 1007 43 -964
==========================================
- Hits 6557 240 -6317
+ Misses 1460 19 -1441
+ Partials 233 11 -222 |
therve
approved these changes
Jun 20, 2019
ofek
pushed a commit
that referenced
this pull request
Jun 20, 2019
* Do not compile regexes on each run - Keep a cache of already compiled regexes (they will always be the same) - Alphanumeric strings an be simply matched for `==` instead of using RE. * Deduplicate loop as per CR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
==instead of using RE.